feat(test2): Support empty parameter list in #[test]
#164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20307320772Details
💛 - Coveralls |
epage
approved these changes
Dec 17, 2025
Collaborator
epage
left a comment
epage
left a comment
There was a problem hiding this comment.
Let me know when you rebase since github doesn't always send notifications for rewrites of history
This supports using the `test` attribute on function with no parameters:
```
#[libtest2::test]
fn simple_test() {
...
}
```
skogseth
force-pushed
the
empty-parameter-list
branch
from
39a8227 to
c733043
Compare
These tests aim to specifically test that the macros accept various edge cases that a user might expect us to support. This includes: - No parameters - Return result (with and without context as a parameter) - Include context as a parameter, but ignore it - Include context as a parameter and pattern match on it
skogseth
force-pushed
the
empty-parameter-list
branch
from
c733043 to
6bbfaf5
Compare
Contributor
Author
|
@epage rebased |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using the
#[test]attribute on functions with no parameters (previously these tests had to take theTestContextparameter as the only argument). So code like this should now work as expected:Other parameter combinations are not supported.
Part of #13.