Skip to content

Conversation

@dajoropo
Copy link

@dajoropo dajoropo commented Nov 22, 2025

  • Code moved and relocated.
  • Changed use of org.Mockito.Matchers.any by org.Mockito.ArgumentMatchers.any (previous was deprecated in v2 and no longer present in v4).
  • Temporally deactivated jacoco for the new module as coverage check makes the build fail.
  • Adapted main README file link.

@scordio scordio requested a review from Copilot November 22, 2025 13:28
@scordio scordio self-assigned this Nov 22, 2025
@scordio scordio added the event: Hack.Commit.Push A topic worked on during a Hack.Commit.Push event label Nov 22, 2025
Copilot finished reviewing on behalf of scordio November 22, 2025 13:30
@scordio scordio changed the title #113 move assertj generator maven plugin Import assertj-generator-maven-plugin Nov 22, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR successfully moves the assertj-assertions-generator-maven-plugin into the main assertj-generator repository as part of consolidating related projects. The key changes include:

  • Relocation of all maven plugin code, tests, and resources from a separate repository
  • Update of Mockito imports from deprecated Matchers.any to ArgumentMatchers.any (compatible with Mockito v4)
  • Temporary disabling of JaCoCo coverage checks for the new module to allow the build to pass
  • Update of main README link to point to the new location

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pom.xml Added new maven-plugin module to the parent build
assertj-generator-maven-plugin/pom.xml Maven plugin module configuration with jacoco temporarily disabled
assertj-generator-maven-plugin/src/main/java/**/*.java Core maven plugin implementation files (Mojo, generator, templates, report)
assertj-generator-maven-plugin/src/test/java/**/*.java Test files with updated Mockito imports and test data classes
assertj-generator-maven-plugin/src/test/resources/templates/**/*.txt Custom template files for testing template override functionality
assertj-generator-maven-plugin/README.md Documentation for the maven plugin
README.md Updated link to point to new maven plugin location
CODE_OF_CONDUCT.md Standard code of conduct file
eclipse/assertj-eclipse-formatter.xml Eclipse formatter configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dajoropo and others added 6 commits November 22, 2025 14:32
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

event: Hack.Commit.Push A topic worked on during a Hack.Commit.Push event

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants