Add isNotEmpty to Table assertions#3559
Merged
scordio merged 2 commits intoassertj:3.xfrom Dec 17, 2024
Merged
Conversation
mk868
force-pushed
the
guava-assertions
branch
2 times, most recently
from
8c0700b to
71a8909
Compare
Contributor
Author
|
Branch rebased |
mk868
force-pushed
the
guava-assertions
branch
from
71a8909 to
f869697
Compare
mk868
changed the title
TableAssert#isNotEmpty() added
mk868
force-pushed
the
guava-assertions
branch
2 times, most recently
from
e37628a to
eaf90c3
Compare
Contributor
Author
|
Branch rebased |
Contributor
Author
|
Is there any chance to merge this? |
mk868
force-pushed
the
guava-assertions
branch
from
eaf90c3 to
9a51870
Compare
Member
|
Hi @mk868, sorry for the slow feedback! I just let the pipeline run, you might face some formatting alerts that can be fixed with spotless. Anyway, I'll jump on the PR over the weekend and get back to you. |
scordio
reviewed
Sep 5, 2024
Member
scordio
left a comment
scordio
left a comment
There was a problem hiding this comment.
Just a few cosmetic comments. No worries if you don't have time, I can take care of them during the merge.
...sertj-guava-tests/src/test/java/org/assertj/tests/guava/api/TableAssert_isNotEmpty_Test.java
Outdated
Show resolved
Hide resolved
...sertj-guava-tests/src/test/java/org/assertj/tests/guava/api/TableAssert_isNotEmpty_Test.java
Outdated
Show resolved
Hide resolved
...sertj-guava-tests/src/test/java/org/assertj/tests/guava/api/TableAssert_isNotEmpty_Test.java
Outdated
Show resolved
Hide resolved
...sertj-guava-tests/src/test/java/org/assertj/tests/guava/api/TableAssert_isNotEmpty_Test.java
Show resolved
Hide resolved
mk868
force-pushed
the
guava-assertions
branch
from
9a51870 to
df0f668
Compare
Contributor
Author
|
Thank you for your review! |
scordio
changed the title
TableAssert#isNotEmpty() addedisNotEmpty to Table assertions
Member
|
Thanks for your first contribution, @mk868! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TableAssertcurrently containsisEmpty()assertion, but noisNotEmpty(). I want to extend this to be like other collection assertions.Check List:
Changes in this PR:
isNotEmpty()added to theTableAssertclassTableAssert#isNotEmpty()TableAssert_isEmpty_Test#should_fail_if_actual_is_null()test method