Rewrite a test to use junit 5 and kotlin-test assertions. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would kill the dependencies on spek (which has run into issues with running tests in the IDE) and assertj. In my opinion it doesn't hurt readablilty of the tests at all. AnyTest is an example of how this looks, eventually all tests should be ported over.
nishtahir
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would kill the dependencies on spek (which has run into issues with
running tests in the IDE) and assertj. In my opinion it doesn't hurt
readablilty of the tests at all.
AnyTest is an example of how this looks, eventually all tests should be
ported over.