Skip to content

Add a tutorial for the advanced order types and documentation for the complex clearing#303

Merged
nick-harder merged 129 commits intomainfrom
advanced_order_example
Feb 21, 2024
Merged

Add a tutorial for the advanced order types and documentation for the complex clearing#303
nick-harder merged 129 commits intomainfrom
advanced_order_example

Conversation

@adamsjohanna
Copy link
Contributor

No description provided.

Johanna Adams and others added 30 commits August 24, 2023 11:14
-further investigation is required
-functionality improved to allow SB also to have a mar
-Sb with MAR maybe should be removed
-adjusted tests
@adamsjohanna adamsjohanna linked an issue Feb 20, 2024 that may be closed by this pull request
42 tasks
@codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (837488c) 76.96% compared to head (96c57e6) 76.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   76.96%   76.76%   -0.21%     
==========================================
  Files          41       41              
  Lines        4702     4695       -7     
==========================================
- Hits         3619     3604      -15     
- Misses       1083     1091       +8     
Flag Coverage Δ
pytest 76.76% <100.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nick-harder nick-harder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments. I will also check the notebook in more details. Did you build and check the documentation?

@nick-harder
Copy link
Member

@adamsjohanna also the tutorial has to be added to the docs, see docs folder for details

@nick-harder nick-harder merged commit 588f56b into main Feb 21, 2024
@nick-harder nick-harder deleted the advanced_order_example branch February 21, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete documentation

4 participants