Skip to content

This commit prepares assume to integrate proper nodal pricing#304

Merged
nick-harder merged 16 commits intomainfrom
prepare-for-nodal-pricing
Mar 12, 2024
Merged

This commit prepares assume to integrate proper nodal pricing#304
nick-harder merged 16 commits intomainfrom
prepare-for-nodal-pricing

Conversation

@nick-harder
Copy link
Member

-delete old examplery nodal pricing
-it will be replaced with pypsa model similar to redispatch
-provide better description and structure for markets API documentation

-delete old examplery nodal pricing
-it will be replaced with pypsa model similar to redispatch
-provide better description and structure for markets API documentation
@nick-harder nick-harder requested a review from maurerle February 20, 2024 15:33
@codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 8.03571% with 103 lines in your changes are missing coverage. Please review.

Project coverage is 77.42%. Comparing base (5e8cbf4) to head (f4e4d0c).

Files Patch % Lines
...ssume/markets/clearing_algorithms/nodal_pricing.py 4.22% 68 Missing ⚠️
assume/common/grid_utils.py 0.00% 22 Missing ⚠️
assume/markets/clearing_algorithms/redispatch.py 0.00% 7 Missing ⚠️
assume/strategies/naive_strategies.py 44.44% 5 Missing ⚠️
assume/markets/clearing_algorithms/__init__.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
- Coverage   77.45%   77.42%   -0.04%     
==========================================
  Files          43       43              
  Lines        5016     4996      -20     
==========================================
- Hits         3885     3868      -17     
+ Misses       1131     1128       -3     
Flag Coverage Δ
pytest 77.42% <8.03%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nick-harder
Copy link
Member Author

@maurerle could you please take a look at this PR?

@maurerle
Copy link
Member

I don't really see the reason in removing things without replacing them with better things, while we have a differen WIP PR open which improves this?

@nick-harder
Copy link
Member Author

@maurerle I have now added the new nodal clearing similar to redispatch structure, but without all the extra funcitons. it uses the same input data and same example folder. Please take a look

@nick-harder nick-harder marked this pull request as draft February 27, 2024 08:13
@nick-harder nick-harder marked this pull request as ready for review February 29, 2024 14:02
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge conflicts need to be resolved here.

@nick-harder
Copy link
Member Author

@maurerle yeah, this one has to be significantly changed to be in line with the new version. I will work on it this week (hopefully) and let you know

@nick-harder nick-harder marked this pull request as draft March 11, 2024 14:35
-remove repeating functions to grid_utils
-change to payment_mechanism for network markets to avoid confusion
@nick-harder nick-harder marked this pull request as ready for review March 12, 2024 12:31
@nick-harder nick-harder requested a review from maurerle March 12, 2024 12:36
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have closer look at the example when I have time, but so far it looks good

@nick-harder nick-harder merged commit 3d44db7 into main Mar 12, 2024
@nick-harder nick-harder deleted the prepare-for-nodal-pricing branch March 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants