-
-
Notifications
You must be signed in to change notification settings - Fork 67
fix: reference/yaml.md #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reference/yaml.md #642
Conversation
WalkthroughThe pull request introduces a new warning note in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
website/reference/yaml.md (1)
240-242: LGTM! Consider enhancing the warning with an example.The warning is well-placed and clearly communicates the issue with
./prefixes. To make it even more helpful, consider adding a before/after example::::warning Don't add `./` Be sure to remove `./` to the beginning of your rules. ast-grep will not recognize the paths if you add `./`. + +Example: +❌ files: ["./src/**/*.js"] +✅ files: ["src/**/*.js"] :::
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
website/reference/yaml.md(2 hunks)
🔇 Additional comments (1)
website/reference/yaml.md (1)
244-244: LGTM! Good practice adding a newline.Adding a newline at the end of the file follows good formatting practices.
add warning for dont add ./ in globbing section
Summary by CodeRabbit
./are not recognized by the tool