-
Notifications
You must be signed in to change notification settings - Fork 51
Description
According to https://docs.asterisk.org/Configuration/Reporting/Call-Detail-Records-CDR/CDR-Specification/#standard-fields some fields with string type and their documented length limit do not (or at least no longer) match with the real world implementation.
Specifically there is a big mismatch for these fields:
- uniqueid
- linkedid
- accountcode
For accountcode the docs state a length limit of 20 characters, however the code says 80 (AST_MAX_ACCOUNT_CODE in include/asterisk/channel.h).
For uniqueid and linkeid the docs state a length limit of 32 characters but the code says 152 (both set to AST_MAX_UNIQUEID in include/asterisk/channel.h by taking AST_MAX_PUBLIC_UNIQUEID + 2 + 1, with AST_MAX_PUBLIC_UNIQUEID being defined as 149).
Please verify my findings are correct and update the documentation accordingly.
I can also prepare a pull request if needed.
The reason I noticed is because we did see warnings of truncated values from res_odbc in our logs for uniqueid.