Skip to content

Development: Clarify PR creation using gh tool. #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gtjoseph merged 1 commit into from
Apr 14, 2026
+1 −1
Merged

Development: Clarify PR creation using gh tool. #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/Development/Policies-and-Procedures/Code-Contribution/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ You should always use option 1 when possible. Unlike Gerrit, GitHub was never d

### Create a Pull Request

When you've finished your work and committed, you can create a new pull request by running `gh pr create --fill --base <base branch>`. The `--fill` option sets the pull request description to the same as the commit message and the `--base` option indicates which asterisk branch the pull request is targeted for (usually master). When prompted where the new branch should be pushed, choose your fork, NOT the upstream repo.
When you've finished your work and committed, you can create a new pull request by running `gh pr create --fill --base <base branch>`. First, run `gh repo set-default --view` to ensure you've set the default repository to the upstream repository (asterisk/asterisk, asterisk/testsuite, etc), then create the pull request with `gh pr create --fill --base <base branch>`. The `--fill` option sets the pull request description to the same as the commit message and the `--base` option indicates which asterisk branch the pull request is targeted for (usually master). When prompted where the new branch should be pushed, choose your fork, NOT the upstream repo.

#### Cherry Picking
Unless there are special circumstances, all changes need to be cherry-picked to the currently-supported major version branches. This is accomplished by adding a special comment to the PR indicating which branches the PR should be cherry-picked to:
Expand Down