realtime: Address test failures in realtime_converter#90
Merged
github-actions[bot] merged 1 commit intoasterisk:masterfrom Jul 16, 2025
Merged
realtime: Address test failures in realtime_converter#90github-actions[bot] merged 1 commit intoasterisk:masterfrom
github-actions[bot] merged 1 commit intoasterisk:masterfrom
Conversation
Contributor
Author
|
cherry-pick-to: 20 |
github-actions
bot
added
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck completed successfully |
github-actions
bot
added
cherry-pick-testing-in-progress
|
Workflow PRCPCheck completed successfully |
gtjoseph
previously requested changes
Jul 15, 2025
github-actions
bot
added
pr-submit-testing-in-progress
and removed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck completed successfully |
gtjoseph
approved these changes
Jul 16, 2025
jcolp
approved these changes
Jul 16, 2025
First, the realtime converter was modified to use pathlib to create parent directories for missing files. Second, the realtime converter was modified to assume 'global' and 'system' section types in pjsip.conf if the optional type identifier was not set for the 'global' and 'system' sections respectively. Lastly, the tests/manager/bridge_actions test was marked as realtime-incompatible. Fixes: asterisk#89
github-actions
bot
added
pr-submit-testing-in-progress
and removed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck completed successfully |
github-actions
bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
and removed
merge-approved
pre-merge-testing-in-progress
labels
|
Successfully merged to branch master and cherry-picked to ["20","21","22"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, the realtime converter was modified to use pathlib to create
parent directories for missing files.
Second, the realtime converter was modified to assume 'global' and
'system' section types in pjsip.conf if the optional type identifier
was not set for the 'global' and 'system' sections respectively.
Lastly, the tests/manager/bridge_actions test was marked as
realtime-incompatible.
Fixes: #89