Skip to content

[red-knot] Understand typing.Type #14904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexWaygood merged 4 commits into from
Dec 11, 2024
Merged

[red-knot] Understand typing.Type #14904

AlexWaygood merged 4 commits into from
Dec 11, 2024

Conversation

@InSyncWithFoo
Copy link
Contributor

@InSyncWithFoo InSyncWithFoo commented Dec 11, 2024

Summary

Resolves #14891.

Test Plan

Markdown tests.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@InSyncWithFoo
Copy link
Contributor Author

InSyncWithFoo commented Dec 11, 2024

This has one small problem: Inheriting from Type results in an MRO with both type and Generic, but Mro::of_class_impl() expects only one returned value from ClassBase::try_from_ty(). Fixing this would require quite a few significant changes here and there; should I try to do so, or should it be left as a TODO for now?

@MichaReiser MichaReiser added the ty Multi-file analysis & type inference label Dec 11, 2024
@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 11, 2024

This has one small problem: Inheriting from Type results in an MRO with both type and Generic, but Mro::of_class_impl() expects only one returned value from ClassBase::try_from_ty(). Fixing this would require quite a few significant changes here and there; should I try to do so, or should it be left as a TODO for now?

Fine to just TODO all that for now. We don't even understand that typing.Generic is a class at all right now!

AlexWaygood
AlexWaygood approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood enabled auto-merge (squash) December 11, 2024 10:57
@AlexWaygood AlexWaygood merged commit f30227c into astral-sh:main Dec 11, 2024
20 checks passed
@InSyncWithFoo InSyncWithFoo deleted the rk-typing-type branch December 11, 2024 12:54
TheBits pushed a commit to TheBits/ruff that referenced this pull request Dec 11, 2024
@InSyncWithFoo @AlexWaygood @TheBits
[red-knot] Understand typing.Type (astral-sh#14904)
0efd217 
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
carljm
carljm reviewed Dec 11, 2024
View reviewed changes
crates/red_knot_python_semantic/resources/mdtest/type_of/typing_dot_Type.md

class A: ...

def _(c: Type, d: Type[A], e: Type[A]):
Copy link
Contributor

@carljm carljm Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the e argument exist here?

Copy link
Contributor Author

@InSyncWithFoo InSyncWithFoo Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't there originally. Probably a small oversight.

Copy link
Member

@AlexWaygood AlexWaygood Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think I screwed that up when simplifying the mdtests a little :-)

@carljm
Copy link
Contributor

carljm commented Dec 11, 2024

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@MichaReiser MichaReiser Awaiting requested review from MichaReiser

@sharkdp sharkdp Awaiting requested review from sharkdp

Assignees

No one assigned

Labels

ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[red-knot] Understand typing.Type

4 participants

@InSyncWithFoo @AlexWaygood @carljm @MichaReiser