dependencies: switch from chrono to jiff
#17376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
requested review from
AlexWaygood,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
Contributor
|
Contributor
|
We weren't really using `chrono` for anything other than getting the current time and formatting it for logs. Unfortunately, this doesn't quite get us to a point where `chrono` can be removed. From what I can tell, we're still bringing it via [`tracing-subscriber`](https://docs.rs/tracing-subscriber/latest/tracing_subscriber/) and [`quick-junit`](https://docs.rs/quick-junit/latest/quick_junit/). `tracing-subscriber` does have an [issue open about Jiff](tokio-rs/tracing#3128), but there's no movement on it. Normally I'd suggest holding off on this since it doesn't get us all of the way there and it would be better to avoid bringing in two datetime libraries, but we are, it appears, already there. In particular, `env_logger` brings in Jiff. So this PR doesn't really make anything worse, but it does bring us closer to an all-Jiff world.
carljm
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't really using
chronofor anything other than getting thecurrent time and formatting it for logs. So the switch to Jiff here
is pretty uninteresting.
Unfortunately, this doesn't quite get us to a point where
chronocan be removed. From what I can tell, we're still bringing it via
tracing-subscriberand
quick-junit.tracing-subscriberdoes have anissue open about Jiff,
but there's no movement on it.
Normally I'd suggest holding off on this since it doesn't get us all of
the way there and it would be better to avoid bringing in two datetime
libraries, but we are, it appears, already there. In particular,
env_loggerbrings in Jiff. So this PR doesn't really make anythingworse, but it does bring us closer to an all-Jiff world.