Skip to content

[flake8-logging] Add fix safety section to LOG001 #18841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylwil3 merged 2 commits into from
Jun 23, 2025
Merged

[flake8-logging] Add fix safety section to LOG001 #18841

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b06ffba
Update direct_logger_instantiation.rs
MeGaGiGaGon Jun 20, 2025
5796ff0
reword
dylwil3 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/ruff_linter/src/rules/flake8_logging/rules/direct_logger_instantiation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ use crate::{Edit, Fix, FixAvailability, Violation};
/// logger = logging.getLogger(__name__)
/// ```
///
/// ## Fix safety
/// This fix is always unsafe, as changing from `Logger` to `getLogger`
/// changes program behavior by will adding the logger to the logging tree.
///
/// [Logger Objects]: https://docs.python.org/3/library/logging.html#logger-objects
#[derive(ViolationMetadata)]
pub(crate) struct DirectLoggerInstantiation;
Expand Down
Loading