[ruff] Add fix for none-not-at-end-of-union (RUF036) #22829
Open
anishgirianish wants to merge 2 commits intoastral-sh:mainfrom
Open
[ruff] Add fix for none-not-at-end-of-union (RUF036) #22829anishgirianish wants to merge 2 commits intoastral-sh:mainfrom
none-not-at-end-of-union (RUF036) #22829anishgirianish wants to merge 2 commits intoastral-sh:mainfrom
Conversation
anishgirianish
changed the title
ruff] Add fix for none-not-at-end-of-union (RUF036) none-not-at-end-of-union (RUF036)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an autofix for
RUF036that movesNoneto the end of union type annotations.Closes #15136
The fix:
|vstyping.Union)Nonevalues instead of deduplicatingNone | Union[int, str])Test Plan
cargo nextest run -p ruff_linter- added test cases for nested unions, comments,default arguments, and mixed styles.