Merged
Conversation
github-actions
bot
requested review from
AlexWaygood,
MichaReiser,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.36%. The number of fully passing files held steady at 79/133. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownprefect
trio
flake8
sphinx
|
Member
|
It appears the latest version of typeshed causes us to timeout on ecosystem-analyzer and some of our benchmarks. |
Member
|
nice PR number though: 24646 |
Member
|
According to Claude: Root causeTwo specific changes in ReproductionBuilt ty in release mode on Baseline (main's typeshed): sympy 1.5s, static-frame 1.4s. So the damage is isolated to Bisection within
|
| Overload applied | sympy | static-frame |
|---|---|---|
add → SupportsAdd/SupportsRAdd overloads |
hang (>90s, 5.7 GB RSS) | hang (>90s) |
mul → SupportsMul/SupportsRMul overloads |
hang (>90s) | 1.1s |
sub → SupportsSub/SupportsRSub overloads |
1.4s | — |
mod → SupportsMod/SupportsRMod overloads |
1.5s | — |
Cross-check: full PR typeshed with just these four overloads (add/sub/mul/mod) reverted back to (Any, Any) -> Any, leaving every other PR change in place (including the new SupportsMod/SupportsRMod protocols added to _typeshed/__init__.pyi): sympy 1.5s. So no other file in the PR contributes.
Member
|
Here's a minimized repro of the hang: from typing import Callable, Protocol
class Foo[In, Out](Protocol):
def method(self, other: In, /) -> Out: ...
def add[In, Out](a: Foo[In, Out], b: In, /) -> Out: ...
def reduce[T](function: Callable[[T, T], T]) -> T: ...
reduce(add)
|
AlexWaygood
force-pushed
the
typeshedbot/sync-typeshed
branch
from
f23399a to
c0f140b
Compare
AlexWaygood
changed the base branch from
main
to
dcreager/avoid-endless-expansion
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-argument-type |
5 | 0 | 4 |
invalid-method-override |
3 | 0 | 0 |
unresolved-attribute |
0 | 1 | 0 |
unused-type-ignore-comment |
1 | 0 | 0 |
| Total | 9 | 1 | 4 |
Raw diff:
cki-lib (https://gitlab.com/cki-project/cki-lib)
- tests/test_misc.py:442:71 error[invalid-argument-type] Argument to bound method `add_argument` is incorrect: Expected `Iterable[Unknown] | None`, found `Unknown | str | timedelta`
+ tests/test_misc.py:442:71 error[invalid-argument-type] Argument to bound method `add_argument` is incorrect: Expected `Iterable[Any] | None`, found `Unknown | str | timedelta`
core (https://github.com/home-assistant/core)
- homeassistant/components/google_generative_ai_conversation/entity.py:177:16 error[unresolved-attribute] Object of type `str` has no attribute `decode`
ibis (https://github.com/ibis-project/ibis)
- ibis/common/deferred.py:465:18 error[invalid-argument-type] Method `__getitem__` of type `bound method dict[((a: Any, b: Any, /) -> Any) | ((a: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, b: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, /) -> Any) | ([_T_co](a: _SupportsInversion[_T_co], /) -> _T_co) | ([_T_co](a: _SupportsNeg[_T_co], /) -> _T_co), str].__getitem__(key: ((a: Any, b: Any, /) -> Any) | ((a: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, b: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, /) -> Any) | ((a: _SupportsInversion[_T_co], /) -> _T_co) | ((a: _SupportsNeg[_T_co], /) -> _T_co), /) -> str` cannot be called with key of type `(...) -> Unknown` on object of type `dict[((a: Any, b: Any, /) -> Any) | ((a: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, b: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, /) -> Any) | ([_T_co](a: _SupportsInversion[_T_co], /) -> _T_co) | ([_T_co](a: _SupportsNeg[_T_co], /) -> _T_co), str]`
+ ibis/common/deferred.py:465:18 error[invalid-argument-type] Method `__getitem__` of type `bound method dict[Overload[[_T_contra, _T_co](a: SupportsAdd[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRAdd[_T_contra, _T_co], /) -> _T_co] | Overload[[_T_contra, _T_co](a: SupportsSub[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRSub[_T_contra, _T_co], /) -> _T_co] | Overload[[_T_contra, _T_co](a: SupportsMul[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRMul[_T_contra, _T_co], /) -> _T_co] | ... omitted 5 union elements, str].__getitem__(key: Overload[(a: SupportsAdd[_T_contra, _T_co], b: _T_contra, /) -> _T_co, (a: _T_contra, b: SupportsRAdd[_T_contra, _T_co], /) -> _T_co] | Overload[(a: SupportsSub[_T_contra, _T_co], b: _T_contra, /) -> _T_co, (a: _T_contra, b: SupportsRSub[_T_contra, _T_co], /) -> _T_co] | Overload[(a: SupportsMul[_T_contra, _T_co], b: _T_contra, /) -> _T_co, (a: _T_contra, b: SupportsRMul[_T_contra, _T_co], /) -> _T_co] | ... omitted 5 union elements, /) -> str` cannot be called with key of type `(...) -> Unknown` on object of type `dict[Overload[[_T_contra, _T_co](a: SupportsAdd[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRAdd[_T_contra, _T_co], /) -> _T_co] | Overload[[_T_contra, _T_co](a: SupportsSub[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRSub[_T_contra, _T_co], /) -> _T_co] | Overload[[_T_contra, _T_co](a: SupportsMul[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRMul[_T_contra, _T_co], /) -> _T_co] | ... omitted 5 union elements, str]`
- ibis/common/deferred.py:484:18 error[invalid-argument-type] Method `__getitem__` of type `bound method dict[((a: Any, b: Any, /) -> Any) | ((a: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, b: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, /) -> Any) | ([_T_co](a: _SupportsInversion[_T_co], /) -> _T_co) | ([_T_co](a: _SupportsNeg[_T_co], /) -> _T_co), str].__getitem__(key: ((a: Any, b: Any, /) -> Any) | ((a: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, b: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, /) -> Any) | ((a: _SupportsInversion[_T_co], /) -> _T_co) | ((a: _SupportsNeg[_T_co], /) -> _T_co), /) -> str` cannot be called with key of type `(...) -> Unknown` on object of type `dict[((a: Any, b: Any, /) -> Any) | ((a: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, b: _SupportsDunderLE | _SupportsDunderGE | _SupportsDunderGT | _SupportsDunderLT, /) -> Any) | ([_T_co](a: _SupportsInversion[_T_co], /) -> _T_co) | ([_T_co](a: _SupportsNeg[_T_co], /) -> _T_co), str]`
+ ibis/common/deferred.py:484:18 error[invalid-argument-type] Method `__getitem__` of type `bound method dict[Overload[[_T_contra, _T_co](a: SupportsAdd[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRAdd[_T_contra, _T_co], /) -> _T_co] | Overload[[_T_contra, _T_co](a: SupportsSub[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRSub[_T_contra, _T_co], /) -> _T_co] | Overload[[_T_contra, _T_co](a: SupportsMul[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRMul[_T_contra, _T_co], /) -> _T_co] | ... omitted 5 union elements, str].__getitem__(key: Overload[(a: SupportsAdd[_T_contra, _T_co], b: _T_contra, /) -> _T_co, (a: _T_contra, b: SupportsRAdd[_T_contra, _T_co], /) -> _T_co] | Overload[(a: SupportsSub[_T_contra, _T_co], b: _T_contra, /) -> _T_co, (a: _T_contra, b: SupportsRSub[_T_contra, _T_co], /) -> _T_co] | Overload[(a: SupportsMul[_T_contra, _T_co], b: _T_contra, /) -> _T_co, (a: _T_contra, b: SupportsRMul[_T_contra, _T_co], /) -> _T_co] | ... omitted 5 union elements, /) -> str` cannot be called with key of type `(...) -> Unknown` on object of type `dict[Overload[[_T_contra, _T_co](a: SupportsAdd[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRAdd[_T_contra, _T_co], /) -> _T_co] | Overload[[_T_contra, _T_co](a: SupportsSub[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRSub[_T_contra, _T_co], /) -> _T_co] | Overload[[_T_contra, _T_co](a: SupportsMul[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRMul[_T_contra, _T_co], /) -> _T_co] | ... omitted 5 union elements, str]`
+ ibis/util.py:261:45 error[invalid-argument-type] Argument to function `reduce` is incorrect: Expected `Iterable[SupportsRMul[Literal[1], Literal[1]]]`, found `tuple[Literal[7, 24, 60, 1000], ...] | tuple[Literal[4, 3], ...]`
jax (https://github.com/google/jax)
+ jax/_src/internal_test_util/test_harnesses.py:2218:47 error[invalid-argument-type] Argument to function `__new__` is incorrect: Expected `Iterable[SupportsSub[SupportsRSub[Never, Unknown], Unknown]]`, found `Unknown | tuple[Literal[2]]`
+ jax/_src/internal_test_util/test_harnesses.py:2218:62 error[invalid-argument-type] Argument to function `__new__` is incorrect: Expected `Iterable[SupportsRSub[SupportsSub[SupportsRSub[SupportsSub[SupportsRSub[Never, Unknown], Unknown], Unknown], Unknown], Unknown]]`, found `Unknown | tuple[Literal[1]]`
materialize (https://github.com/MaterializeInc/materialize)
+ misc/python/materialize/cli/mzcompose.py:1044:9 error[invalid-method-override] Invalid override of method `parse_known_args`: Definition is incompatible with `argparse.ArgumentParser.parse_known_args`
+ misc/python/materialize/cli/mzcompose.py:1056:9 error[invalid-method-override] Invalid override of method `parse_known_args`: Definition is incompatible with `ArgumentParser.parse_known_args`
+ misc/python/materialize/mzcompose/composition.py:101:9 error[invalid-method-override] Invalid override of method `parse_known_args`: Definition is incompatible with `ArgumentParser.parse_known_args`
meson (https://github.com/mesonbuild/meson)
- mesonbuild/msetup.py:392:58 error[invalid-argument-type] Argument to bound method `parse_args` is incorrect: Expected `Sequence[str] | None`, found `(CMDOptions & Top[list[Unknown]]) | list[str]`
+ mesonbuild/msetup.py:392:58 error[invalid-argument-type] Argument to bound method `parse_args` is incorrect: Expected `Iterable[str] | None`, found `(CMDOptions & Top[list[Unknown]]) | list[str]`
mitmproxy (https://github.com/mitmproxy/mitmproxy)
+ mitmproxy/utils/strutils.py:125:43 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
prefect (https://github.com/PrefectHQ/prefect)
+ src/prefect/server/utilities/database.py:528:50 error[invalid-argument-type] Argument to function `_sqlite_strfinterval` is incorrect: Expected `ColumnElement[int | float]`, found `ColumnElement[str] | ColumnElement[Any]`
sympy (https://github.com/sympy/sympy)
+ sympy/tensor/array/expressions/array_expressions.py:405:13 error[invalid-argument-type] Argument to function `reduce` is incorrect: Expected `(Unknown | Basic, Unknown | Basic, /) -> Unknown | Basic`, found `Overload[[_T_contra, _T_co](a: SupportsAdd[_T_contra, _T_co], b: _T_contra, /) -> _T_co, [_T_contra, _T_co](a: _T_contra, b: SupportsRAdd[_T_contra, _T_co], /) -> _T_co]`
AlexWaygood
force-pushed
the
typeshedbot/sync-typeshed
branch
from
c0f140b to
ad0ac77
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close and reopen this PR to trigger CI