fix for invalid unpacking target panic#24945
Closed
samuelcolvin wants to merge 1 commit intoastral-sh:mainfrom
Closed
fix for invalid unpacking target panic#24945samuelcolvin wants to merge 1 commit intoastral-sh:mainfrom
samuelcolvin wants to merge 1 commit intoastral-sh:mainfrom
Conversation
samuelcolvin
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
Member
|
Confirmed this is fixed by #24663 which was open but unmerged. |
Author
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The text
'',~=in a stub or imported file currently causes a panic.No idea if this is the best solution - I'm mostly submit the PR as an MRE + most obvious fix.
Test Plan
There's a test.