[ty] Preserve declaration order when synthesizing class fields#25249
Draft
charliermarsh wants to merge 1 commit into
Draft
[ty] Preserve declaration order when synthesizing class fields#25249charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
eadeec6 to
bba1d8c
Compare
bba1d8c to
33a711c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this change, field synthesis could accidentally follow symbol-table order instead of class-body declaration order in pathological cases like:
Here,
intcan be interned before its own declaration because it already appears inTop[int].This PR carries a stable declaration ordinal through declaration lookup and uses it when building
own_fields().Closes astral-sh/ty#3493.