Skip to content

Remove unused pub code from workspace#19565

Open
charliermarsh wants to merge 2 commits into
mainfrom
charlie/hawk
Open

Remove unused pub code from workspace#19565
charliermarsh wants to merge 2 commits into
mainfrom
charlie/hawk

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented May 26, 2026

Summary

This PR runs hawk over the uv codebase to:

  1. Remove dead code (i.e., code marked as pub that isn't called by any other crates).
  2. Reduce visibility of symbols (i.e., to make code non-pub if only called internally, etc.).

I skimmed through the changes and added exceptions where they felt warranted (to hawk.toml). I've included the hawk.toml file in the prior commit, but am excluding it from being committed, since it's not at a point that we have automated tooling.

@charliermarsh charliermarsh added build:release Enable building release binaries for a pull request build:docker Enable building Docker images for a pull request labels May 26, 2026
@charliermarsh charliermarsh force-pushed the charlie/hawk branch 6 times, most recently from 83491cf to 07a3eba Compare June 2, 2026 23:39
@charliermarsh charliermarsh changed the title Run CI for removed workspace code Remove unused pub code from workspace Jun 3, 2026
@charliermarsh charliermarsh marked this pull request as ready for review June 3, 2026 01:02
@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Jun 3, 2026
@charliermarsh charliermarsh requested review from konstin and zanieb June 3, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build:docker Enable building Docker images for a pull request build:release Enable building release binaries for a pull request internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant