Skip to content

Conversation

@CosmoMatt
Copy link
Collaborator

@CosmoMatt CosmoMatt commented Feb 27, 2024

This addresses the bugs outlined in issue #183 kindly provided by @PhilippMisofCH

  • dl array corrected to float64 in rotation function.
  • explicitly cast spin to absolute value to avoid negative power warnings in JAX in various places
  • change Risbo arg check function to raw string literal (r"""...) to allow LaTeX equation.

@CosmoMatt CosmoMatt self-assigned this Feb 27, 2024
@CosmoMatt
Copy link
Collaborator Author

@PhilippMisofCH so long as it's ok with you, I can add you as a contributor for debugging. No worries if not.

@codecov
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.77%. Comparing base (5ccf24b) to head (16f0efc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files          24       24           
  Lines        2601     2601           
=======================================
  Hits         2387     2387           
  Misses        214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhilippMisofCH
Copy link
Contributor

Sure! I will continue using this library for some time and I'm happy to help with small bugs.

@CosmoMatt
Copy link
Collaborator Author

@all-contributors please add @PhilippMisofCH for bug

@allcontributors
Copy link
Contributor

@CosmoMatt

I've put up a pull request to add @PhilippMisofCH! 🎉

@jasonmcewen
Copy link
Contributor

Thanks for flagging this @PhilippMisofCH ! And thanks for addressing so quickly @CosmoMatt ! Have jsut reviewed and approved.

@CosmoMatt CosmoMatt merged commit b82e065 into main Feb 27, 2024
@CosmoMatt
Copy link
Collaborator Author

closes #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants