Skip to content

Support "docker-compose.override.yml" files for local customization#231

Merged
schnie merged 1 commit intomasterfrom
compose-override.yml
Jun 12, 2019
Merged

Support "docker-compose.override.yml" files for local customization#231
schnie merged 1 commit intomasterfrom
compose-override.yml

Conversation

@ashb
Copy link
Contributor

@ashb ashb commented Jun 7, 2019

This lets people mount extra files in, or run extra side-car services
that they might want for local development

This lets people mount extra files in, or run extra side-car services
that they might want for local development
@ashb ashb requested a review from andriisoldatenko June 7, 2019 09:59
Copy link
Contributor

@andriisoldatenko andriisoldatenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need practical tests.

@ashb
Copy link
Contributor Author

ashb commented Jun 7, 2019

I tested this locally with the following docker-compose.override.yml file:

version: '2'
services:
  scheduler:
    volumes:
      - .:/usr/local/airflow

@ashb ashb requested a review from schnie June 7, 2019 16:20
@andriisoldatenko
Copy link
Contributor

@schnie please merge it when you have free min

@schnie schnie merged commit de76a6f into master Jun 12, 2019
@schnie schnie deleted the compose-override.yml branch June 12, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants