Skip to content

Feature/add config setters#24

Merged
schnie merged 2 commits intomasterfrom
feature/add-config-setters
Mar 2, 2018
Merged

Feature/add config setters#24
schnie merged 2 commits intomasterfrom
feature/add-config-setters

Conversation

@andscoop
Copy link
Contributor

@andscoop andscoop commented Feb 22, 2018 •
edited
Loading

This PR

  • adds ability to get and set configs from CLI
  • changes project configs from strings to struct repr of configs. This allows
    • dot notation access to cfgs
    • properties to be stored inline with cfg ie
      • gettable bool
      • settable bool
      • projectAccessible
      • etc.
  • closes Set configurations #22

@andscoop andscoop requested a review from schnie February 22, 2018 18:30
@ryw ryw added this to the 3/7/18 milestone Feb 25, 2018
@schnie schnie merged commit 8af7047 into master Mar 2, 2018
@andscoop andscoop deleted the feature/add-config-setters branch April 18, 2018 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schnie schnie Awaiting requested review from schnie schnie is a code owner

Assignees

@schnie schnie

Labels

None yet

Projects

None yet

Milestone

3/14/18

Development

Successfully merging this pull request may close these issues.

Set configurations

3 participants

@andscoop @ryw @schnie