TST: avoid collecting setup_package module for reproject#45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a problem I found in #43.
The problem was that this build-only module, which has a dependency on setuptools (not a runtime dependency) is collected from, as all modules, when doctest is enabled (and it always is, here). It used to pass silently in Python 3.11 and older because these versions shipped setuptools alongside the standard library, but 3.12 and newer don't.
This build-only module has to ship as part of a source install, and setuptools has no good way (that I know of) of excluding files just from wheels. So, even though there's no good reason to include it in wheels, it's understandable that this is the current state of affairs.