Generalize package: configurable core package and flat column list#55
Merged
Merged
Conversation
- packages.yaml: replace the python_versions list with a core_package
block (pypi_name, module, repo_url, optional dev_index_urls), a
dashboard_title, and a flat columns list of {python, variant} pairs
- config.py: new module that loads and validates the config, shared
by run and dashboard
- run.py: resolve_specs takes the core block instead of literal
"astropy" and the nightly index constants; iterate the columns list
instead of nesting python and variant loops; --variant/--python
become filters over the columns; result JSON key astropy -> core
- dashboard.py: read column order, title, and core name from config;
group consecutive columns that share a python version under a
spanning header so the classic layout still renders as before
- integration.yml: a setup job parses columns from packages.yaml and
emits the job matrix, so there is one source of truth
astrofrog
changed the title
Member
Author
|
This seems to work fine for us and also for a few sunpy packages from local testing, so I'm going to go ahead and merge this and then we can refine in subsequent PRs if @Cadair tries this out properly for the Sunpy ecosystem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that other ecosystems (e.g. sunpy) can use this and the config for the columns to show is now a flat list rather than a matrix of python versions x variants, for more flexibility.
@Cadair with this you could do something like: