-
-
Notifications
You must be signed in to change notification settings - Fork 106
Add announcement and update team for 5.1 #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment below otherwise looks good!
team.html
Outdated
| <li>Luke G. Bouma</li> | ||
| <li>Luke Kelley</li> | ||
| <li>Luz Paz</li> | ||
| <li>luz paz</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change deliberate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I just ran the script so this change is coming from the Astropy credit.rst page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the script gets the credits.rst from main, which does not yet contain my updates on the v5.1.x branch. I will backport those changes to main, and fix the lower case issue, but that can wait a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I already did the update on main: astropy/astropy#13187
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is this resolved or need to be fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to fix it on the astropy repo, but since I would like to send this release email (which needs the PR merged before) I did the change here.
|
I don't think failure is related |
|
But... do we have to fix it anyway so the webpage would be deployed? |
|
The URL still exists, so I restarted the job. |
|
Still failed. Maybe that site blocked the CI. Works locally. >>> url = 'https://bayesicfitting.nl/'
>>> import requests
>>> r = requests.get(url)
>>> r.ok
TrueAnyways, let's just merge. But if this doesn't render, we need to figure out how to get around this error. |
|
Thanks, all! |
|
How do you even get to the |
|
Thanks @pllim. The page is not referenced but it's just a copy of the announcement email, linked from the release email. E.g. for 5.0: |
No description provided.