Skip to content

Conversation

@saimn
Copy link
Contributor

@saimn saimn commented May 30, 2022

No description provided.

@pllim pllim requested a review from a team May 31, 2022 13:10
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment below otherwise looks good!

team.html Outdated
<li>Luke G. Bouma</li>
<li>Luke Kelley</li>
<li>Luz Paz</li>
<li>luz paz</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change deliberate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I just ran the script so this change is coming from the Astropy credit.rst page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the script gets the credits.rst from main, which does not yet contain my updates on the v5.1.x branch. I will backport those changes to main, and fix the lower case issue, but that can wait a bit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I already did the update on main: astropy/astropy#13187

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is this resolved or need to be fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to fix it on the astropy repo, but since I would like to send this release email (which needs the PR merged before) I did the change here.

@pllim
Copy link
Member

pllim commented Jun 2, 2022

I don't think failure is related

Checking BayesicFitting
 - verifying keys
 - verifying URLs
   ERROR: Home URL for BayesicFitting - https://bayesicfitting.nl/ - did not work
 - verifying PyPI name
 - verifying review

@pllim
Copy link
Member

pllim commented Jun 2, 2022

But... do we have to fix it anyway so the webpage would be deployed?

@pllim
Copy link
Member

pllim commented Jun 2, 2022

The URL still exists, so I restarted the job.

@pllim
Copy link
Member

pllim commented Jun 2, 2022

Still failed. Maybe that site blocked the CI. Works locally.

>>> url = 'https://bayesicfitting.nl/'
>>> import requests
>>> r = requests.get(url)
>>> r.ok
True

Anyways, let's just merge. But if this doesn't render, we need to figure out how to get around this error.

@pllim pllim merged commit e548bf8 into astropy:main Jun 2, 2022
@pllim
Copy link
Member

pllim commented Jun 2, 2022

Thanks, all!

@pllim
Copy link
Member

pllim commented Jun 2, 2022

How do you even get to the announcements/release-5.1.html page from the main page?

@saimn saimn deleted the 5.1-updates branch June 2, 2022 20:12
@saimn
Copy link
Contributor Author

saimn commented Jun 2, 2022

Thanks @pllim. The page is not referenced but it's just a copy of the announcement email, linked from the release email. E.g. for 5.0:
https://groups.google.com/g/astropy-dev/c/c-NOBh0ntRM/m/-X_MMX8bBAAJ (at the end of the email)
https://www.astropy.org/announcements/release-5.0.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants