Skip to content

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Apr 18, 2018

This should fix the travis issues we see. I didn't have the time to look into more details why the more recent version stopped working on Python 2, it may be a keyring issue or a conda issue, but almost certainly not an issue in astroquery so I suggest we live with the workaround for now (and if users run into the same thing with 2.7, we advise them to use an <12.0 version).

This should close #1097

@astropy-bot
Copy link

astropy-bot bot commented Apr 18, 2018

Hi there @bsipocz 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #1103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1103   +/-   ##
=======================================
  Coverage   64.44%   64.44%           
=======================================
  Files         139      139           
  Lines       11139    11139           
=======================================
  Hits         7179     7179           
  Misses       3960     3960

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108aad7...626502b. Read the comment docs.

@bsipocz
Copy link
Member Author

bsipocz commented Apr 18, 2018

I'm going ahead and merge this now. We still have the timeout issue that I'm still unable to reproduce locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

travis-ci failures: keyring in py2.7?

1 participant