Limit keyring version for legacy Python #1103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the travis issues we see. I didn't have the time to look into more details why the more recent version stopped working on Python 2, it may be a keyring issue or a conda issue, but almost certainly not an issue in astroquery so I suggest we live with the workaround for now (and if users run into the same thing with 2.7, we advise them to use an <12.0 version).
This should close #1097