Skip to content

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Apr 27, 2018

Well, apparently it was the same issue as the ones in #1103

The limits btw may be removed soon as the fix is already been merged, see #1122

@astropy-bot
Copy link

astropy-bot bot commented Apr 27, 2018

Hi there @bsipocz 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@bsipocz
Copy link
Member Author

bsipocz commented Apr 27, 2018

This should come back all green!

@codecov
Copy link

codecov bot commented Apr 27, 2018

Codecov Report

Merging #1123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1123   +/-   ##
=======================================
  Coverage   64.16%   64.16%           
=======================================
  Files         139      139           
  Lines       11228    11228           
=======================================
  Hits         7204     7204           
  Misses       4024     4024

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f955121...581ee76. Read the comment docs.

@bsipocz bsipocz force-pushed the tests_keyring_pin branch from dd6a7f4 to a6a3243 Compare April 27, 2018 15:29
@bsipocz bsipocz force-pushed the tests_keyring_pin branch from a6a3243 to 39e5551 Compare April 27, 2018 15:38
@bsipocz
Copy link
Member Author

bsipocz commented Apr 27, 2018

Green all the way! 🎉

@bsipocz bsipocz merged commit 3b5936a into astropy:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant