Skip to content

Use continuation when downloading files from MAST #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

Use continuation when downloading files from MAST #3448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81337fc
Use continuation when downloading files
snbianco Oct 28, 2025
e88d686
changelog
snbianco Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ mast
- Filtering by file extension or by a string column is now case-insensitive in ``MastMissions.filter_products``
and ``Observations.filter_products``. [#3427]

- Switch to use HTTP continuation for partial downloads. [#3448]
Copy link
Member

@bsipocz bsipocz Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this needs a changelog as being an internal change, but probably doesn't hurt either.



Infrastructure, Utility and Other Changes and Additions
-------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion astroquery/mast/collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ def download_hsc_spectra(self, spectra, *, download_dir=None, cache=True, curl_f
bundler_response = response[0].json()

local_path = os.path.join(download_dir, "{}.sh".format(download_file))
self._download_file(bundler_response['url'], local_path, head_safe=True, continuation=False)
self._download_file(bundler_response['url'], local_path, head_safe=True)

status = "COMPLETE"
msg = None
Expand Down
4 changes: 2 additions & 2 deletions astroquery/mast/observations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,11 +670,11 @@ def download_file(self, uri, *, local_path=None, base_url=None, cache=True, clou
else:
log.warning("Falling back to mast download...")
self._download_file(escaped_url, local_path,
cache=cache, head_safe=True, continuation=False,
cache=cache, head_safe=True,
verbose=verbose)
else:
self._download_file(escaped_url, local_path,
cache=cache, head_safe=True, continuation=False,
cache=cache, head_safe=True,
verbose=verbose)

# check if file exists also this is where would perform md5,
Expand Down
Loading