Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3567 +/- ##
==========================================
+ Coverage 73.04% 73.08% +0.03%
==========================================
Files 219 219
Lines 20545 20569 +24
==========================================
+ Hits 15008 15032 +24
Misses 5537 5537 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
snbianco
force-pushed
the
deprecate-objectname
branch
2 times, most recently
from
84fc385 to
8ddf73d
Compare
snbianco
force-pushed
the
deprecate-objectname
branch
from
8ddf73d to
5844c52
Compare
bsipocz
approved these changes
Mar 25, 2026
Member
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
This all looks good, thanks!
Unrelated issue that came up while I was running the remote tests for this PR:
- the name resolution sometimes running into timeouts, so I would consider defaulting into a coordinate input for the remote tests rather than using
object_name. I mean we should test object_name, but maybe just once and all the rest should use a coordinate rather than doing the additional name resolution with the remote service?
Either case, that is something for a follow-up.
|
|
||
| @class_or_instance | ||
| @deprecated_renamed_argument('objectname', 'object_names', since='0.4.11') | ||
| @deprecated_renamed_argument('objectname', 'object_names', since='0.4.12') |
Member
There was a problem hiding this comment.
Thanks for spotting this and fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
objectnameparameter inCatalogs,Observations,Tesscut, andutilsis deprecated in favor ofobject_name.I also used this PR to fix an unintentional backwards compatibility issue that was introduced in #3540. Previously, users could input a single coordinate string with a comma separating the RA and declination (
"20, -30"). The code introduced in that PR splits the string on commas, assuming that coordinates are only separated by a space, which breaks this workflow. I implemented a corner case that detects this historical single-coordinate input and works around it to still return results.