Skip to content

Initial implementation of logging #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2014
Merged

Initial implementation of logging #40

merged 3 commits into from
Apr 28, 2014

Conversation

@mwcraig
Copy link
Member

@mwcraig mwcraig commented Apr 25, 2014

Not sure I like this implementation. In particular, function signatures are lost when they are decorated.

Workarounds are:

  • Use the decorator package, which restores signatures but does an eval for each decorated function to do so.
  • Automate insertion of the original function signature in the docstring as part of the decorator.

mwcraig added a commit that referenced this pull request Apr 28, 2014
@mwcraig
Merge pull request #40 from mwcraig/logging
578f74f 
Initial implementation of logging

Now that function signatures are preserved in the docs this is ready, I think....though I fully expect it to change down the road.
@mwcraig mwcraig merged commit 578f74f into astropy:master Apr 28, 2014
@mwcraig mwcraig deleted the logging branch April 28, 2014 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mwcraig