Make PixelAperture.area an abstract method#223
Conversation
|
This change is not consistent with It says there:
But I can't find a point of use of |
|
@cdeil - I think we didn't make it an abstract method as it may not be straightforward to define in future or user defined aperture classes. However the method may well became obsolete, as it was only used for some speeding up when calculating the errors. |
|
I think the One concrete example where |
|
@larrybradley So what do I have to do ... just add Feel free to do this yourself somewhere else if it's easier that explaining to me what to do. |
|
@cdeil I've never used it with a base class. I'd try that first, but you may need to add |
|
And I guess tests should be added ... I'll try this on Saturday, but if someone gets to it before I'd be happy. |
Make PixelAperture.area an abstract method
@bsipocz @astrofrog Does it make sense to make PixelAperture.area an abstract method?
All tests pass before or after this change ... I made it because my editor was complaining here about the missing
self.