pytest deprecation warning : MarkInfo objects are deprecated #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly. Tried to change this according to their suggestion : Please use node.get_closest_marker(name) or node.iter_markers(name). https://docs.pytest.org/en/latest/mark.html#updating-code Test failing report for astropy/regions : https://travis-ci.org/astropy/regions/jobs/387743813
|
@sushobhana - Do you know which one is the oldest pytest version that supports the new API? Accepting this PR now will mean that our minimum required version will need to be changed, too. |
|
@bsipocz - I have no idea! But let me check. |
|
Should I close this, since the tests are now passing? |
|
The deprecations are still there, we just ignore them for the moment. For the long term, we'll need this definitely, but whether we can merge it in now or not really depends on my question above about the minimum version number if makes us to require. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Tried to change this according to their suggestion : Please use node.get_closest_marker(name) or node.iter_markers(name).
https://docs.pytest.org/en/latest/mark.html#updating-code
Test failing report for astropy/regions : https://travis-ci.org/astropy/regions/jobs/387743813