Skip to content

Deep copy bug in ElementWithXSIType#756

Merged
bsipocz merged 2 commits into
astropy:mainfrom
andamian:tap-deepcopy
Jun 4, 2026
Merged

Deep copy bug in ElementWithXSIType#756
bsipocz merged 2 commits into
astropy:mainfrom
andamian:tap-deepcopy

Conversation

@andamian
Copy link
Copy Markdown
Contributor

Fix for #755

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.88%. Comparing base (9754692) to head (b107d8a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage   79.88%   79.88%           
=======================================
  Files          91       91           
  Lines       10311    10312    +1     
=======================================
+ Hits         8237     8238    +1     
  Misses       2074     2074           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz added this to the v1.9 milestone May 26, 2026
Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a chaneglog entry? I don't think I'll do another bugfix, next release will be 1.9 sometimes next week.

I also wonder if we could do a reasonable test that trips without this PR.

@bsipocz bsipocz added the bug label May 26, 2026
@andamian andamian marked this pull request as ready for review June 3, 2026 23:47
@andamian
Copy link
Copy Markdown
Contributor Author

andamian commented Jun 3, 2026

Could you please add a chaneglog entry? I don't think I'll do another bugfix, next release will be 1.9 sometimes next week.

I also wonder if we could do a reasonable test that trips without this PR.

I was hoping to pick up another issue or two but ran out of time...

@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Jun 4, 2026

I was hoping to pick up another issue or two but ran out of time...

I totally hear you.

OTOH, I'm happy to do more bugfix releases between the interops when/if we have PRs merged :)

Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bsipocz bsipocz merged commit 4b413ea into astropy:main Jun 4, 2026
13 checks passed
@andamian andamian deleted the tap-deepcopy branch June 4, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants