Skip to content

Remove support for ASTROPY_LT_13 in tests#222

Merged
cdeil merged 1 commit intoastropy:masterfrom
cdeil:modern
Sep 15, 2018
Merged

Remove support for ASTROPY_LT_13 in tests#222
cdeil merged 1 commit intoastropy:masterfrom
cdeil:modern

Conversation

@cdeil
Copy link
Copy Markdown
Member

@cdeil cdeil commented Sep 15, 2018

This PR removes support for ASTROPY_LT_13 from some tests.

I don't know what Astropy version we support here, but I think it's clear that Astropy < 1.3 is not our target.

@astrofrog @keflavich - OK?

@cdeil cdeil added the testing label Sep 15, 2018
@cdeil cdeil added this to the 0.4 milestone Sep 15, 2018
Copy link
Copy Markdown
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think supporting Astropy 2.x would be fine. Maybe we should make that explicit in the list of dependencies.

@cdeil cdeil merged commit 19405f6 into astropy:master Sep 15, 2018
@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Sep 16, 2018

Is there a roadmap of when to merge this into core, wasn't it 3.2 being aimed for a couple of months ago? If that's still the aim for this package, then we there isn't much need to keep a wide range of supported astropy versions.

@cdeil
Copy link
Copy Markdown
Member Author

cdeil commented Sep 16, 2018

No, there is no roadmap or concrete plan yet. I think astropy.healpix should be done first, because it's the basis for MOC region (#219), and astropy.healpix still needs a lot of work.

I agree requiring Astropy >=2 for astropy.regions would be OK. Probably that's already what we test in CI anyways and all that's needed is a mention in setup.py and install instructions. On the other hand, that adds little value, and most things might actually work with Astropy >= 1.3, so I won't add that now. But if someone thinks it's useful, please send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants