Skip to content

Conversation

@rosteen
Copy link
Contributor

@rosteen rosteen commented Dec 3, 2025

Fixes #1279. The upstream NDCube __pow__ method uses a _new_instance method that is incompatible with specutils due to some unexpected keywords. This PR overrides that with a version of __pow__ that has a couple compatibility fixes.

@rosteen rosteen added this to the 2.3 milestone Dec 3, 2025
@rosteen rosteen added bug data objects Core data objects like Spectrum1D or SpectralCollection labels Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.94%. Comparing base (9f2b391) to head (5692f92).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
specutils/spectra/spectrum.py 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
- Coverage   86.98%   86.94%   -0.04%     
==========================================
  Files          63       63              
  Lines        4857     4873      +16     
==========================================
+ Hits         4225     4237      +12     
- Misses        632      636       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rosteen rosteen merged commit a747841 into astropy:main Dec 8, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug data objects Core data objects like Spectrum1D or SpectralCollection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spectrum.__init__ does not support Spectrum attributes

1 participant