Conversation
Collaborator
|
I am still somewhat surprised that this turns up now, and why SE2 does not have this problem. Other than that it is fine. Thanks fro wrapping that up. |
Member
Author
|
From what I see in SE2 code, it does not check on the value of npix being 0, but that should propagate a NaN around, so I am not sure how is that avoided. I merge this in any case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Martin,
It turns out that the error is still there in some cases. For instance, with a cell size of 32 (same image, band i from double Sersic).
It seems to be because sigma is not quite 0, but rather a very very small double greater than 0.
I have changed the checks on sigma > 0 to sigma > epsilon.
Does this make sense?