Replace FFTW_MEASURE with FFTW_ESTIMATE#256
Merged
Conversation
Member
|
I need to have a look at why the test break. The convolution should be equivalent! |
Member
|
Some tests actually broke because of the background, but some others did "break" because of the estimate, and it seems we are not alone (*). I don't think it is so much the fault of the change as the brittleness of the tests. They are too sensitive to fluctuations, and one dancing pixel from a source is enough to break some. I am looking at this. (*) Actually, just using 0.51 instead of 0.5 as the maximum distance to consider a successful cross-match suffices to fix it. |
Collaborator
Author
|
Concerning the background, you are using the new background now? That maximum distance is always a problem (in my small experience). I think we should keep an eye on this reproducibility issue. |
ayllon
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced FFTW_MEASURE with FFTW_ESTIMATE, which "should" make the FFTW make deterministic (according to the link I found). I tested it a bit, the thresholded image were always identical.
@ayllon please have a further look, I just followed the first google result.