Conversation
* Background median rms to be passed around * Allow the output to access sources directly
marcschefer
reviewed
Jun 2, 2020
marcschefer
reviewed
Jun 2, 2020
SEImplementation/SEImplementation/Configuration/DetectionImageConfig.h
Outdated
Show resolved
Hide resolved
* FitsImageSource inherit from it and changes its handling of headers * readFitsKeyword and getFitsHeaders are kept for compatibility * Added test for double and string headers, including quotes
Member
|
@ayllon I'll let you do the merge as I don't know if Alexandria 2.16 is considered released... |
Member
Author
|
Good point. It is not, yet. I will do it tomorrow after the telecon if we decide to release sourcex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for #243