Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
parse_mapinsrc/steam/vdf.rsfail (returnNone) when a closing}is not found instead of silently accepting EOF.parseto callskip_whitespace()and reject the input if any non-whitespace remains after a parsed root object.src/steam/vdf.rsto assert strict behavior: change the unclosed-brace test to expect failure and addtest_parse_rejects_trailing_non_whitespace_textandtest_parse_rejects_second_root_objectto cover trailing garbage and multiple top-level objects.Testing
cargo fmt --allsuccessfully.PKG_CONFIG_PATH=/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/share/pkgconfig cargo test -q steam::vdf::tests, but the test run cannot complete in this environment due to missing system GNOME/GLib pkg-config metadata (glib-2.0.pc), so unit tests should be validated in a developer environment or CI where the nativeglib-2.0dev package is installed.Codex Task