Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
is_success_or_reboot_codehelper and updated runtime installer logic to accept exit codes0and3010as success for both VC++ and .NET installers insrc/external/runtime_installer.rs, plus unit tests for the helper.find_mod_rootdeterministic by sorting directory entries before checking formod.iniand addedremove_pathand logic inmove_dir_contentsto remove existing targets before moving, insrc/setup/common.rs, plus tests for deterministic selection and overwriting behavior.src/external/proton.rsto accept names likeProton 9,Proton 9.0 (Beta),Proton 8.0-4, and added a test to ensure directories without wine binaries are ignored when selecting Proton.src/steam/library.rsto skip library paths that are empty/whitespace-only, restrictsonic.exefallback to SADX only, and added tests for whitespace paths and symlinked library de-duplication (Unix-only).src/steam/vdf.rsto strip a leading UTF-8 BOM before parsing and added a unit test for BOM handling.Testing
cargo test; all tests completed successfully.test_is_success_or_reboot_code, Proton parsing tests,test_find_mod_root_prefers_deterministic_order,test_move_dir_contents_overwrites_existing_file, Steam library tests for whitespace and symlink dedupe, andtest_parse_with_utf8_bom, and all passed.Codex Task