Skip to content

Conversation

@asus4
Copy link
Owner

@asus4 asus4 commented Jul 2, 2025

No description provided.

@asus4 asus4 requested a review from Copilot July 2, 2025 11:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds Editor support for native dialogs by introducing a dedicated DialogEditor implementation, enriching public APIs with XML documentation, and updating DialogManager to route dialog calls through the new editor handler.

  • Added XML doc comments on interfaces and classes for clarity.
  • Introduced DialogEditor for Unity Editor dialog support and wired it into DialogManager.
  • Updated DialogManager public API (labels, show/dismiss methods) and fixed lifecycle region typo.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Packages/com.github.asus4.nativedialog/Runtime/Internal/IDialogReceiver.cs Added summary docs to the dialog-receiver interface.
Packages/com.github.asus4.nativedialog/Runtime/Internal/IDialog.cs Added summary docs to the platform-dialog interface.
Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogMock.cs Added doc comments to the mock dialog class (now unused).
Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogIOS.cs Added summary docs to the iOS dialog implementation.
Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogAndroid.cs Added summary docs to the Android dialog implementation.
Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogEditor.cs New Editor-based dialog implementation for Unity Editor mode.
Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogEditor.cs.meta Metadata for the new DialogEditor asset.
Packages/com.github.asus4.nativedialog/Runtime/DialogManager.cs Switched Editor support to DialogEditor, added XML docs to public methods, corrected region typo.
Assets/NativeDialogSample.cs Added XML docs to sample usage component.
Comments suppressed due to low confidence (2)

Packages/com.github.asus4.nativedialog/Runtime/Internal/IDialogReceiver.cs:7

  • DialogEditor calls receiver?.OnCancel(...) but IDialogReceiver only defines OnSubmit. Add an OnCancel(string idStr) method to the interface to match its use.
    internal interface IDialogReceiver

Packages/com.github.asus4.nativedialog/Runtime/Internal/DialogMock.cs:10

  • DialogMock is no longer instantiated by DialogManager (Editor now uses DialogEditor). Consider removing DialogMock or restoring its intended use to avoid dead code.
    internal sealed class DialogMock : MonoBehaviour, IDialog

@asus4 asus4 merged commit 77a80cb into main Jul 2, 2025
@asus4 asus4 deleted the class-comments branch July 2, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants