Skip changelog's test when the dataprovider returns nothing #1983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Nov 7, 2025
|
|
||
| if (0 === \count($branches)) { | ||
| self::markTestSkipped('Cannot find the master branch'); | ||
| yield [null, null, null]; |
Member
There was a problem hiding this comment.
why yielding null which will trigger a type error ?
Also, markTestSkipped was throwing, which was stopping the data provider.
Now, such case would trigger a notice when accessing $branches[0]
Member
Author
There was a problem hiding this comment.
yielding null is a mistake and should be fixed by #1985
Throwing an exception in the dataprovider breaks the test suite => https://github.com/async-aws/aws/actions/runs/19174431727/job/54815354423#step:8:11
yielding a dummy value is the single way I found to prevent PhpUnit from throwing an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failling test when the DataProviders returns an empty list.
https://github.com/async-aws/aws/actions/runs/19167154579/job/54790443661#step:8:52