Skip to content

Conversation

@trowski
Copy link
Contributor

@trowski trowski commented Oct 4, 2016

While this issue was discussed in #4, Awaitable was a compromise to (mostly my) objections to using the name Promise, avoiding confusion from the standard interface not having a then() method. However, after using and discussing awaitables for the past few months, it has become clear that Promise is a more ubiquitous term. Thus I propose we change Awaitable to Promise.

I still feel there will be some confusion over not having a then() method, but this confusion can be solved with highlighted documentation.

@trowski
Copy link
Contributor Author

trowski commented Oct 20, 2016

Ping @assertchris @WyriHaximus @AndrewCarterUK @rdlowrey @jsor @sagebind @mbonneau @joelwurtz

Do any of you have opinions on this rename to Promise?

@WyriHaximus
Copy link
Member

I'm in favour 👍 and with some extra documentation we can make perfectly clear why we want with when instead of then

@bwoebi
Copy link
Member

bwoebi commented Oct 20, 2016

@WyriHaximus
Copy link
Member

@bwoebi it is, and was referring to that piece of documentation as something extra on top of the normal documentation. Could have done that better though 🤐

@jsor
Copy link

jsor commented Oct 21, 2016

I don't mind a rename. I'm pretty sure though that there will be a lot of confusion with standard Promises/Thenables event if it's documented.

@joelwurtz
Copy link

As an user i found Awaitable to be better, prior to see this interface i exclusively used Promise and the traditional flow of chaining them without thinking to more about the implementation.

When i see this spec, i was wondering why it was not called Promise so i look more on the implementation and certainly ask a bunch of stupid questions.

However that was the name Awaitable that begin this, having this class called Promise would, certainly, have confuse me even more...

@trowski trowski merged commit 4013918 into master Nov 14, 2016
@kelunik kelunik deleted the rename branch November 14, 2016 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants