Use register_shutdown_function for panic #44
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure about that one. It prevents us from directly printing to STDERR and instead deferring to PHP to handle that. PHP will automatically choose what to do based on ini settings like
display_errors.One potential downside of this approach is people using
exitinside callbacks registered withregister_shutdown_function. That would result in hiding the exception.This might happen if you run the event loop from a
register_shutdown_function. RxPHP does this in its examples to reduce the boilerplate for these. In that case ourexit(255);here directly exits without executing any further shutdown functions.Feedback and opinions are very welcome.