Move profiler_tick into spawn_blocking#132
Merged
Merged
Conversation
rcoh
force-pushed
the
spawn-blocking-ops
branch
from
ce2e9de to
7d3402f
Compare
…ment - Add TickError::JfrFileMissing variant instead of misusing EmptyInactiveFile for the case where jfr_file is None in tick_blocking - Clarify Drop comment to note it intentionally skips the status reset that self.stop() would do since the struct is being dropped
jlizen
approved these changes
May 13, 2026
Collaborator
jlizen
left a comment
jlizen
left a comment
There was a problem hiding this comment.
So we still block in the ProfilerState::Drop and try_final_report? Seems fine, this is a clear improvement.
| ) | ||
| } | ||
|
|
||
| async fn profiler_tick<E: ProfilerEngine>( |
Collaborator
There was a problem hiding this comment.
should we add a doc comment that this is not cancel-safe anymore? since if it is dropped inside an eg select loop, we permanently lose profiler state
| }; | ||
|
|
||
| let report_metadata = ReportMetadata { | ||
| instance: agent_metadata.as_ref().unwrap(), |
Collaborator
|
@rcoh this one is ready for you if you didn't see, idk if you care to make the tweaks or merge |
jlizen
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📬 Issue #, if available: #131
✍️ Description of changes: dial9 revealed long polls caused by profiler_tick (~20ms)
🔏 By submitting this pull request