deny missing docs #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
force-pushed
the
deny-missing-docs
branch
from
f65f878 to
950e3dc
Compare
added 2 commits
April 29, 2025 17:53
arielb1
force-pushed
the
deny-missing-docs
branch
from
950e3dc to
a66c64a
Compare
rcoh
approved these changes
Apr 29, 2025
| //! | ||
| //! #[cfg(tokio_unstable)] | ||
| //! { | ||
| //! rt.on_before_task_poll(|_| async_profiler_agent::pollcatch::before_poll_hook()) |
Collaborator
There was a problem hiding this comment.
It's probably worth briefly discussing the expected (low) performance impact of this
arielb1
force-pushed
the
deny-missing-docs
branch
from
0724f49 to
1257c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs to everything
The main goal is the big crate doc
📬 Issue #, if available:
✍️ Description of changes:
🔏 By submitting this pull request