Skip to content

fix: move over to forked oclif#254

Merged
asyncapi-bot merged 12 commits intoasyncapi:masterfrom
Souvikns:oclif-fork
Mar 11, 2022
Merged

fix: move over to forked oclif#254
asyncapi-bot merged 12 commits intoasyncapi:masterfrom
Souvikns:oclif-fork

Conversation

@Souvikns
Copy link
Member

@Souvikns Souvikns commented Mar 10, 2022

Description
Since oclif manifest command didn't have any way to get logs, this PR is installing a fork version of oclif and adding logs so that we can understand what is going on with the command.

Forked repo - https://github.com/Souvikns/oclif
adding logs - https://github.com/Souvikns/oclif/blob/main/src/commands/manifest.ts

"nyc": "^14.1.1",
"oclif": "^2.5.0",
"oclif": "github:Souvikns/oclif#main",
"rimraf": "^3.0.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Souvikns
Copy link
Member Author

Clearly, the issue is with installing the library from GitHub. I found this maybe we can follow this, actions/setup-node#214. Maybe I am doing something wrong with setting up https://github.com/Souvikns/oclif do I also need to commit node_modules @derberg?

@derberg
Copy link
Member

derberg commented Mar 10, 2022

@Souvikns you definitely do not want to commit node_modules 😅 as it is just for testing really, can you just publish fork to your private npm? in linked issue folks say it helped to workaround the issue

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Souvikns
Copy link
Member Author

Souvikns commented Mar 11, 2022

@derberg I released a new npm library with all the logs, once we are done with this I will delete that library.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

btw, in a few days NPM will not allow you to delete the library. This is to prevent bad behavior in dependency manager. But yeah, not a problem to have it there. Might be you will need it in the future 😄

@Souvikns
Copy link
Member Author

Now I will delete the tag and merge this PR.

@Souvikns
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 8c18e97 into asyncapi:master Mar 11, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments