-
-
Notifications
You must be signed in to change notification settings - Fork 14
feat: inital project setup #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
magicmatatjahu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only few comments :) Great job!
jonaslagoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aayushmau5 I am guessing you want this merged asap, and not wait for Lukasz, so I am just gonna help you move forward. Looking good 👍
I would suggest adding a single index.ts in the src folder as the "initial version", that way package.json main file can be located 🙂
We also need to trigger a manual release before merging this PR to make sure our workflow picks up the version.
@aayushmau5 do you have access to do this?
I don't think so. (I'm not sure) |
Do you see a |
|
Nope. |
Alright, we need @derberg to add you as code owner once he gets back. Feel free to ping him with the request already so he is aware of it when he gets back 🙂 I will create the release so we can merge the PR 👍 |
Will do 😄
Thanks 🙏 |
|
@aayushmau5 You probably need to wait for review from your Postman mentor :) Ping us when you want to merge it :) |
|
@aayushmau5 can you change the PR title to use conventional commit syntax? It has to be similar to |
vinitshahdeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aayushmau5 LGTM. 👏
@jonaslagoni we can merge it now.
|
🎉 This PR is included in version 0.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
package.json,package-lock.json&tsconfig.json).jest&ts-jestfor testing.semantic-releasepackage.