Skip to content

Conversation

@aayushmau5
Copy link
Member

Description

  • Initalized NodeJS + Typescript Project(package.json, package-lock.json & tsconfig.json).
  • Added eslint files.
  • Added jest & ts-jest for testing.
  • Added semantic-release package.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only few comments :) Great job!

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aayushmau5 I am guessing you want this merged asap, and not wait for Lukasz, so I am just gonna help you move forward. Looking good 👍

I would suggest adding a single index.ts in the src folder as the "initial version", that way package.json main file can be located 🙂

We also need to trigger a manual release before merging this PR to make sure our workflow picks up the version.

@aayushmau5 do you have access to do this?

@aayushmau5
Copy link
Member Author

We also need to trigger a manual release before merging this PR to make sure our workflow picks up the version.
@aayushmau5 do you have access to do this?

I don't think so. (I'm not sure)

@jonaslagoni
Copy link
Member

We also need to trigger a manual release before merging this PR to make sure our workflow picks up the version.
@aayushmau5 do you have access to do this?

I don't think so. (I'm not sure)

Do you see a Create a new release under the main repo (https://github.com/asyncapi/diff) on the right side under Releases?

@aayushmau5
Copy link
Member Author

Nope.

@jonaslagoni
Copy link
Member

jonaslagoni commented Jun 7, 2021

Nope.

Alright, we need @derberg to add you as code owner once he gets back. Feel free to ping him with the request already so he is aware of it when he gets back 🙂

I will create the release so we can merge the PR 👍

@aayushmau5
Copy link
Member Author

Alright, we need @derberg to add you as code owner once he gets back. Feel free to ping him with the request already so he is aware of it when he gets back.

Will do 😄

I will create the release so we can merge the PR

Thanks 🙏

@magicmatatjahu
Copy link
Member

@aayushmau5 You probably need to wait for review from your Postman mentor :) Ping us when you want to merge it :)

@jonaslagoni
Copy link
Member

@aayushmau5 can you change the PR title to use conventional commit syntax? It has to be similar to feat: initial project setup That way the automated workflow will bump the version in package.json and add a new release on NPM so it goes from 0.0.1 -> 0.1.0

@aayushmau5 aayushmau5 changed the title Added Inital project setup feat: inital project setup Jun 7, 2021
Copy link
Collaborator

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aayushmau5 LGTM. 👏
@jonaslagoni we can merge it now.

@jonaslagoni jonaslagoni merged commit 844102a into asyncapi:master Jun 7, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants