Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

Use interpolation for variables inside calc()#102

Merged
lgavillet merged 1 commit intomasterfrom
sled-fix-css-calc-interpolation
Jul 7, 2017
Merged

Use interpolation for variables inside calc()#102
lgavillet merged 1 commit intomasterfrom
sled-fix-css-calc-interpolation

Conversation

@sled
Copy link
Contributor

@sled sled commented Jun 28, 2017

Until now this was not compiled properly, i.e the output was

/* line 17, /Users/xxx/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/mtl-1.1.6/app/assets/stylesheets/mtl/extend/_chips.scss */
.chip .close {
  font-size: calc($chip-font-size + 3px);
  height: 22px;
  line-height: 23px;
  padding-left: calc($chip-font-size + 3px)/2;
}

@sled sled requested a review from lgavillet June 28, 2017 15:00
@sled
Copy link
Contributor Author

sled commented Jun 28, 2017

just noticed that $chip-font-size is also in px so one could write simply $chip-font-size + 3px not sure what was the problem in commit eb4e91c @ruinunes ?

@lgavillet
Copy link
Contributor

👍

@lgavillet lgavillet merged commit ad34afb into master Jul 7, 2017
@lgavillet lgavillet deleted the sled-fix-css-calc-interpolation branch July 7, 2017 06:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants