This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Enhance dropdowns within .simple_form container#27
Merged
Conversation
This change fixes <select/> dropdowns within .simple_form <form>'s.
Otherwise each select input requires additional manual markup like:
= f.input :field, collection: c, input_html: { 'data-mtl-select': true }
This change makes this obselete.
lwe
force-pushed
the
lwe-simple-form-select
branch
from
1b92f6a to
760e221
Compare
Contributor
|
👍 |
Contributor
Author
|
Danke. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes
<select/>dropdowns within .simple_form<form>'s. Otherwise each select input requires additional manual markup like:= f.input :field, collection: c, input_html: { 'data-mtl-select': true }This change makes this obsolete.
@lgavillet or @marcopluess please review and merge, thanks.