Conversation
| background-color: $mtl-layout-default-header-bg; | ||
| @include clearafter; | ||
|
|
||
| * { |
There was a problem hiding this comment.
uh... can we avoid things like that by chance, really not a fan of using *, as this would mess up, e.g. the following:
<div class="grey-color">asdsa <span>didum</span></div>
isn't simply setting color: enough + a few specific overrides for links?
There was a problem hiding this comment.
hmmm in a way yes and no at the same time:
YES&NO: your example would be messed up... BUT your would have full control anyway:
<div class="grey-text">asdsa <span class="grey-text">didum</span></div> would work, as all .COLOR-text classes override the color with !important.
NO: we don't want to have people to use these overrides in the default layout anyway, right? we'd rather extend the configurability.
YES: we could add specific overrides instead of the star...
NO: ...but does it help the readability/maintainability of the sass layout? I mean we have: navs, titles, icons, dropdowns, other infos and potential custom stuff in each project which I cannot predict. * would cover like 90% of ALL cases. I'd rather prefer having the * there instad of defining each and every possible element that is/could maybe be there.
Food for thought.
a34f376 to
236a257
Compare
|
@lwe please review... obviously IF the builds pass :D |
236a257 to
3821216
Compare

No description provided.