Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

Mapl extend layout configurability#41

Merged
marcopluess merged 4 commits intomasterfrom
mapl-extend-layout-configurability
Jul 26, 2016
Merged

Mapl extend layout configurability#41
marcopluess merged 4 commits intomasterfrom
mapl-extend-layout-configurability

Conversation

@marcopluess
Copy link

No description provided.

@marcopluess
Copy link
Author

@sled: extended the configuration of the default layout.

@lwe: please review. will add the changes and documentation later. ah and can you help me to get the builds through green? somehow I need the railties changes from simis branch to run it inside lendit.

@marcopluess
Copy link
Author

it enables this, btw:

screen shot 2016-07-22 at 16 03 48

background-color: $mtl-layout-default-header-bg;
@include clearafter;

* {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh... can we avoid things like that by chance, really not a fan of using *, as this would mess up, e.g. the following:

<div class="grey-color">asdsa <span>didum</span></div>

isn't simply setting color: enough + a few specific overrides for links?

Copy link
Author

@marcopluess marcopluess Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm in a way yes and no at the same time:

YES&NO: your example would be messed up... BUT your would have full control anyway:
<div class="grey-text">asdsa <span class="grey-text">didum</span></div> would work, as all .COLOR-text classes override the color with !important.

NO: we don't want to have people to use these overrides in the default layout anyway, right? we'd rather extend the configurability.

YES: we could add specific overrides instead of the star...
NO: ...but does it help the readability/maintainability of the sass layout? I mean we have: navs, titles, icons, dropdowns, other infos and potential custom stuff in each project which I cannot predict. * would cover like 90% of ALL cases. I'd rather prefer having the * there instad of defining each and every possible element that is/could maybe be there.

Food for thought.

@marcopluess marcopluess force-pushed the mapl-extend-layout-configurability branch 2 times, most recently from a34f376 to 236a257 Compare July 26, 2016 08:48
@marcopluess
Copy link
Author

@lwe please review... obviously IF the builds pass :D

@marcopluess marcopluess force-pushed the mapl-extend-layout-configurability branch from 236a257 to 3821216 Compare July 26, 2016 08:50
@marcopluess marcopluess merged commit d8cc5bd into master Jul 26, 2016
@marcopluess marcopluess deleted the mapl-extend-layout-configurability branch July 26, 2016 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants